@types/testing-library__cypress is breaking my CI build #98

williamoliveira · 2020-01-02T16:56:28Z

Apparently it tries to download two versions of Cypress simultaneously. One that I defined ("cypress": "3.8.1") and one at @types/testing-library__cypress ("cypress": "^3.5.0").

Relevant issue at cypress side: cypress-io/cypress#4595.

cypress-testing-library version: "@testing-library/cypress": "5.0.2"
node version: 10.18
npm (or yarn) version: 6.13

CI LOG:

error /app/node_modules/@types/testing-library__cypress/node_modules/cypress: Command failed.
Exit code: 1
Command: node index.js --exec install
Arguments: 
Directory: /app/node_modules/@types/testing-library__cypress/node_modules/cypress
Output:
Installing Cypress (version: 3.6.1)

[16:39:59]  Downloading Cypress     [started]
[16:40:00]  Downloading Cypress      0% 0s [title changed]
[16:40:00]  Downloading Cypress      3% 3s [title changed]
[16:40:00]  Downloading Cypress      4% 5s [title changed]
[16:40:00]  Downloading Cypress      4% 8s [title changed]
[16:40:00]  Downloading Cypress      5% 8s [title changed]
[16:40:00]  Downloading Cypress      6% 8s [title changed]
[16:40:00]  Downloading Cypress      7% 9s [title changed]
[16:40:01]  Downloading Cypress      8% 9s [title changed]
[16:40:01]  Downloading Cypress      9% 9s [title changed]
[16:40:01]  Downloading Cypress      10% 9s [title changed]
[16:40:01]  Downloading Cypress      12% 8s [title changed]
[16:40:01]  Downloading Cypress      13% 8s [title changed]
[16:40:01]  Downloading Cypress      13% 9s [title changed]
[16:40:01]  Downloading Cypress      14% 9s [title changed]
[16:40:01]  Downloading Cypress      15% 9s [title changed]
[16:40:01]  Downloading Cypress      15% 10s [title changed]
[16:40:02]  Downloading Cypress      16% 9s [title changed]
[16:40:02]  Downloading Cypress      18% 9s [title changed]
[16:40:02]  Downloading Cypress      19% 9s [title changed]
[16:40:02]  Downloading Cypress      21% 8s [title changed]
[16:40:02]  Downloading Cypress      22% 8s [title changed]
[16:40:02]  Downloading Cypress      24% 7s [title changed]
[16:40:02]  Downloading Cypress      25% 7s [title changed]
[16:40:02]  Downloading Cypress      26% 7s [title changed]
[16:40:02]  Downloading Cypress      27% 7s [title changed]
[16:40:02]  Downloading Cypress      29% 7s [title changed]
[16:40:03]  Downloading Cypress      31% 6s [title changed]
[16:40:03]  Downloading Cypress      34% 6s [title changed]
[16:40:03]  Downloading Cypress      35% 6s [title changed]
[16:40:03]  Downloading Cypress      36% 6s [title changed]
[16:40:03]  Downloading Cypress      39% 5s [title changed]
[16:40:03]  Downloading Cypress      40% 5s [title changed]
[16:40:03]  Downloading Cypress      45% 4s [title changed]
[16:40:03]  Downloading Cypress      47% 4s [title changed]
[16:40:03]  Downloading Cypress      60% 2s [title changed]
[16:40:04]  Downloading Cypress      73% 1s [title changed]
[16:40:04]  Downloading Cypress      85% 1s [title changed]
[16:40:04]  Downloading Cypress      100% 0s [title changed]
[16:40:06]  Downloading Cypress      100% 0s [failed]
[16:40:06] → The Cypress App could not be downloaded.

Does your workplace require a proxy to be used to access the Internet? If so, you must configure the HTTP_PROXY environment variable before downloading Cypress. Read more: https://on.cypress.io/proxy-configuration

Otherwise, please check network connectivity and try again:

----------

URL: https://download.cypress.io/desktop/3.6.1?platform=linux&arch=x64
Error: Corrupted download

Expected downloaded file to have checksum: 1c887ae436316e59f53be57d0c0a8c1e4b483ad40dd7b7e90d2da740f777eb64f93838d09446a2c48cd68f0292d710f1f53a03afff4e0f2d47d410767c90387a
Computed checksum: 47134d7281c1188d04d0cdfb48d0ee5f4ee69342137a3b21c09228362718055bc63eb58f67c69584c709bcba9193c1e094957d83ca6bbd393dd65ea3b5ab090c

Expected downloaded file to have size: 152981007
Computed size: 162396738

The text was updated successfully, but these errors were encountered:

jcreamer898 · 2020-01-08T22:18:13Z

Same issue causing our Jenkins process to asplode. Haha.

Curious, why is @types/testing-library__cypress even listed as a dependency? Shouldn't that be up to the consumer of this project to install?

I bet this would fix itself if @types/testing-library__cypress was moved to devDependencies eh?

Should resolve issues with corrupted download mentioned in testing-library#98

Niceplace · 2020-01-11T16:50:04Z

I'm experiencing the same issue here but @testing-library/cypress": "5.0.2" is already in our devDependencies :/

weyert · 2020-01-11T17:16:15Z

Guess, we should make cypress a peer dependency?

nhducit · 2020-01-12T15:05:31Z

I think you guys can workaround by using yarn resolution

package.json
https://yarnpkg.com/lang/en/docs/selective-version-resolutions/

  "resolutions": {
    "cypresss": "1.2.3" // use whichever version you want
  }

…ng-library/issues/98\#issuecomment-573423911)

kentcdodds · 2020-01-28T17:42:33Z

@weyert's suggestion is correct. It should be a peerDep with a very generous version range.

kentcdodds · 2020-01-28T17:45:57Z

I just made a PR: DefinitelyTyped/DefinitelyTyped#41917

Closing here because there's nothing we can do in this repo at this point :) Thanks! (Also, sorry it took me so long to address this. I kinda took a break and it's been hard to get back on top of things 😅)

jcreamer898 · 2020-02-07T13:50:55Z

Thanks @kentcdodds!

kaiyoma · 2020-08-05T22:11:04Z

What happened here? It looks like the PR was undone and this types package is still doing a full install of Cypress. We're seeing two different versions of Cypress in our node_modules because of this. Why aren't peer dependencies being used?

ref: testing-library/cypress-testing-library#98

…ent data updates testing setup (#26500) * chore(e2e-dev-runtime): bump @testing-library/cypress * chore(e2e-dev-runtime): scope fake-data source plugin data refreshes * force single cypress version ref: testing-library/cypress-testing-library#98

jbojcic1 · 2020-08-23T14:18:34Z

I still have this issue. I had Cypress 4.12.1 and I installed @testing-library/cypress 6.0.1 which has @types/testing-library__cypress ^5.0.6 as a dependency. Ended up with two Cypress versions 4.12.1 and 5.0.0 which was breaking my CI build.

kentcdodds · 2020-08-23T14:26:22Z

Try @testing-library/[email protected] :)

kentcdodds · 2020-08-23T14:26:41Z

(Note, that should work because the types are now within the module)

…ent data updates testing setup (#26500) * chore(e2e-dev-runtime): bump @testing-library/cypress * chore(e2e-dev-runtime): scope fake-data source plugin data refreshes * force single cypress version ref: testing-library/cypress-testing-library#98

jcreamer898 added a commit to jcreamer898/cypress-testing-library that referenced this issue Jan 8, 2020

move types to devDependencies

3c1e0d8

Should resolve issues with corrupted download mentioned in testing-library#98

jcreamer898 mentioned this issue Jan 8, 2020

move types to devDependencies #99

Closed

3 tasks

tlrobinson referenced this issue in metabase/metabase Jan 15, 2020

Fix cypress install (https://github.com/testing-library/cypress-testi…

e7ba102

…ng-library/issues/98\#issuecomment-573423911)

kentcdodds mentioned this issue Jan 28, 2020

@types/testing-library__cypress: Set cypress version range to be very generous so users do not download two cypress versions DefinitelyTyped/DefinitelyTyped#41917

Merged

9 tasks

kentcdodds closed this as completed Jan 28, 2020

valscion mentioned this issue Feb 11, 2020

TL enforces cypress 4.0.1 #121

Closed

pieh added a commit to gatsbyjs/gatsby that referenced this issue Aug 17, 2020

force single cypress version

b8013c4

ref: testing-library/cypress-testing-library#98

pieh mentioned this issue Aug 17, 2020

chore(e2e-dev-runtime): bump @testing-library/cypress and adjust current data updates testing setup gatsbyjs/gatsby#26500

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@types/testing-library__cypress is breaking my CI build #98

@types/testing-library__cypress is breaking my CI build #98

williamoliveira commented Jan 2, 2020

jcreamer898 commented Jan 8, 2020 •

edited

Loading

Niceplace commented Jan 11, 2020

weyert commented Jan 11, 2020

nhducit commented Jan 12, 2020 •

edited

Loading

kentcdodds commented Jan 28, 2020

kentcdodds commented Jan 28, 2020

jcreamer898 commented Feb 7, 2020

kaiyoma commented Aug 5, 2020

jbojcic1 commented Aug 23, 2020

kentcdodds commented Aug 23, 2020

kentcdodds commented Aug 23, 2020

@types/testing-library__cypress is breaking my CI build #98

@types/testing-library__cypress is breaking my CI build #98

Comments

williamoliveira commented Jan 2, 2020

jcreamer898 commented Jan 8, 2020 • edited Loading

Niceplace commented Jan 11, 2020

weyert commented Jan 11, 2020

nhducit commented Jan 12, 2020 • edited Loading

kentcdodds commented Jan 28, 2020

kentcdodds commented Jan 28, 2020

jcreamer898 commented Feb 7, 2020

kaiyoma commented Aug 5, 2020

jbojcic1 commented Aug 23, 2020

kentcdodds commented Aug 23, 2020

kentcdodds commented Aug 23, 2020

jcreamer898 commented Jan 8, 2020 •

edited

Loading

nhducit commented Jan 12, 2020 •

edited

Loading